mt-admin Commit - 3b807424bd87

Update more admin pages to use DBAL functions.

darkmorford -

3b807424bd87

Not Reviewed

Context file:

Add another comment

Collapse all files

0 unresolved 0 Resolved

0 General 0 Inline

character-twitter.php ¶ +8 -13

             	check_nonce('new-character-twitter');
             	#Fetch the password from the DB.
-            	$acct = $mtdb->getRow(sprintf("SELECT username, password FROM twitter_user WHERE id = '%d'", $_REQUEST['twitter-account']));
+            	$stmt = $dbConnection->executeQuery('SELECT username, password FROM twitter_user WHERE id = ?', array($_REQUEST['twitter-account']));
+            	$acct = $stmt->fetch();
             	$post_at = strtotime($_REQUEST['date18']);
             		else
             		{
             			#No luck, gotta schedule.
-            			$mtdb->query(
+            			$dbConnection->executeUpdate('INSERT INTO twitter_post (status, user, time, text) VALUES (\'scheduled\', ?, FROM_UNIXTIME(?), ?)',
-            				sprintf("INSERT INTO twitter_post (status, user, time, text)VALUES ('scheduled', '%d', FROM_UNIXTIME('%d'), '%s')",
+            				array($_REQUEST['twitter-account'], $post_at, $_REQUEST['message']));
-            					mysqli_real_escape_string($mtdb->link, $_REQUEST['twitter-account']),
-            					$post_at,
-            					mysqli_real_escape_string($mtdb->link, $_REQUEST['message'])
-            			);
             			$info .= "Your tweet for user " . htmlentities($acct->username) . " has been scheduled.";
             			adminlog('Tweet for account ' . $acct->username . ' has been scheduled.', MTS_TWITTER, MTA_ADD);
             		}
             	}
             }
-            $characters = $mtdb->getAll("SELECT id, username FROM twitter_user ORDER BY username");
+            $characters = $dbConnection->fetchAll('SELECT id, username FROM twitter_user ORDER BY username');
-            $scheduled = $mtdb->getAll("SELECT username, text, status, twitter_post.id AS id, time
+            $scheduled = $dbConnection->fetchAll('SELECT username, text, status, twitter_post.id AS id, time ' .
-            	FROM twitter_post JOIN twitter_user
+            	'FROM twitter_post JOIN twitter_user ON twitter_post.user = twitter_user.id ' .
-            		ON twitter_post.user = twitter_user.id
+            	'WHERE twitter_post.status = \'scheduled\' ORDER BY time');
-            	WHERE twitter_post.status = 'scheduled' ORDER BY time");
             adminhead('Manage Character Twitters');
             adminmenu();

delete-tweet.php ¶ +1 -1

             if($victim)
             {
-            	$r = $mtdb->query("DELETE FROM twitter_post WHERE id = '$victim'");
+            	$r = $dbConnection->executeUpdate('DELETE FROM twitter_post WHERE id = ?', array($victim));
             	if(!$r)
             	{
             		adminlog('Error deleting scheduled tweet ' . $victim, MTS_TWITTER, MTA_DELETE, E_ERROR);

delete-twitter-user.php ¶ +1 -1

             if($victim)
             {
-            	$r = $mtdb->query("DELETE FROM twitter_user WHERE id = '$victim'");
+            	$r = $dbConnection->executeUpdate('DELETE FROM twitter_user WHERE id = ?', array($victim));
             	if(!$r)
             	{
             		adminlog('Error deleting specified twitter user ' . $victim, MTS_TWITTER, MTA_DELETE, E_ERROR);

edit-comic.php ¶ +4 -4

             			if( !is_valid_upload('comicFile') )
             			{
             				adminlog("Image upload failed.", MTS_STRIP, MTA_ADD, E_WARNING);
-            				mtdie('If you want to upload a new comic, you must provide said comic.','Strip upload failed.');
+            				mtdie('If you want to upload a new comic, you must provide said comic.', 'Strip upload failed.');
             			}
             			// get image type and target extension
             			$imagedata = getimagesize($_FILES['comicFile']['tmp_name']);
             			$strip->media = $imagedata[2];
-            			$fileext = $mtdb->getOne( 'SELECT extension FROM media_t WHERE id = ' . (int)$strip->media );
+            			$fileext = $dbConnection->fetchColumn('SELECT extension FROM media_t WHERE id = ?', array($strip->media), array(PDO::PARAM_INT));
             			if(strlen($fileext) < 3)
             			{
             				$imagedata = getimagesize($_FILES['comicFile']['tmp_name']);
             				$strip->media = $imagedata[2];
             			}
-            			$fileext = $mtdb->getOne( 'SELECT extension FROM media_t WHERE id=' . (int)$strip->media );
+            			$fileext = $dbConnection->fetchColumn('SELECT extension FROM media_t WHERE id = ?', array($strip->media), array(PDO::PARAM_INT));
             			if(strlen($fileext) < 3)
             			{
             <h3 class="dbx-handle">Comic Type</h3>
             <div class="dbx-content"><select name="strip_type">
             <?php
-            $types = $mtdb->getAll( 'SELECT id, description FROM strip_t ORDER BY id' );
+            $types = $dbConnection->fetchAll('SELECT id, description FROM strip_t ORDER BY id');
             foreach( $types as $k=>$v )
             	printf('<option value="%s" %s>%s</option>', htmlentities($v->id), ($strip->type == $v->id ? 'selected="selected"' : '' ), htmlentities($v->description));

edit-metatype.php ¶ +6 -1

             auth_redirect(); // Require logged in user to access this page.
-            $type = $mtdb->getRow( 'SELECT id, name FROM meta_t WHERE id=' . (int)$_GET['edit'] )
+            $sql = 'SELECT id, name FROM meta_t WHERE id = ?';
+            $stmt = $dbConnection->prepare($sql);
+            $stmt->bindValue(1, $_GET['edit'], PDO::PARAM_INT);
+            $stmt->execute();
+            $type = $stmt->fetch()
             	or mtdie("Invalid metatype number!");
             adminhead('Metatypes');

manage-comics.php ¶ +4 -4

             if( isset($_GET['page'] )) $page = (int) $_GET['page'];
             $perpage = 15;
-            $start = ($page-1) * $perpage;
+            $start = ($page - 1) * $perpage;
-            $total = ceil( $mtdb->getOne("SELECT count(DISTINCT id) FROM strip") / $perpage );
+            $total = ceil( $dbConnection->fetchColumn('SELECT COUNT(id) FROM strip') / $perpage );
-            $strips = $mtdb->getAll("SELECT id, UNIX_TIMESTAMP(published) as published, type, media, title, book, page FROM strip GROUP BY id ORDER BY id DESC LIMIT $start,$perpage");
+            $strips = $dbConnection->fetchAll('SELECT id, UNIX_TIMESTAMP(published) AS published, type, media, title, book, page FROM strip ORDER BY id DESC LIMIT ?, ?', array($start, $perpage), array(PDO::PARAM_INT, PDO::PARAM_INT));
-            $types_db = $mtdb->getAll("SELECT id,description FROM strip_t");
+            $types_db = $dbConnection->fetchAll('SELECT id, description FROM strip_t');
             $type = array();
             foreach( $types_db as $k ) $type[$k->id]=$k->description;

post-comic.php ¶ +3 -3

             auth_redirect(); // Require logged in user to access this page.
-            $last_type = $mtdb->getOne( 'SELECT type FROM strip ORDER BY id DESC limit 1' );
+            $last_type = $dbConnection->fetchColumn('SELECT type FROM strip ORDER BY id DESC LIMIT 1');
-            $last_strip_id = $mtdb->getOne( 'SELECT MAX(id) FROM strip' );
+            $last_strip_id = $dbConnection->fetchColumn('SELECT MAX(id) FROM strip');
             adminhead('Post Comic');
             adminmenu('post-comic.php');
             <h3 class="dbx-handle">Comic Type</h3>
             <div class="dbx-content"><select name="strip_type">
             <?php
-            $types = $mtdb->getAll( 'SELECT id, description FROM strip_t ORDER BY id' );
+            $types = $dbConnection->fetchAll('SELECT id, description FROM strip_t ORDER BY id');
             foreach( $types as $k=>$v )
             	printf('<option value="%s" %s>%s</option>', htmlentities($v->id), ($last_type == $v->id ? 'selected="selected"' : '' ), $v->description);
             ?>

Comments 0

Write
Preview

You need to be logged in to leave comments. Login now

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings