mt-admin Commit - 749c3253f5e9

Switch more PHP files to use the DBAL.

darkmorford -

749c3253f5e9

Not Reviewed

Context file:

Add another comment

Collapse all files

0 unresolved 0 Resolved

0 General 0 Inline

manage-metatypes.php ¶ +7 -7

             if( isset($_GET['delete']) && (int)$_GET['delete'] ) {
             	check_nonce('delete-metatype-'.(int)$_GET['delete']);
-            	if(! $mtdb->query( 'DELETE FROM meta_t WHERE id=' . (int)$_GET['delete'] ) )
+            	if(! $dbConnection->executeUpdate('DELETE FROM meta_t WHERE id = ?', array($_GET['delete'])))
             	{
             		adminlog("Error on deleting metatype ".(int)$_GET['delete'], MTS_TYPE_META, MTA_DELETE, E_WARNING);
-            		mtdie("Error on update: ". htmlentities(mysqli_error()));
+            		mtdie("Error on update: ". $dbConnection->errorCode());
             	}
             	$info.='<p>Deleted metatype successfully.<p>';
             	adminlog("Metatype ".(int)$_GET['delete']." deleted.", MTS_TYPE_META, MTA_DELETE);
             	$name = trim($_POST['name']);
             	if( check_type_name( $name ) ) {
-            		if(! $mtdb->query( 'INSERT INTO meta_t(name) VALUES("'. mysqli_real_escape_string($mtdb->link, $name) . '")' ) )
+            		if(! $dbConnection->executeUpdate('INSERT INTO meta_t (name) VALUES (?)', array($name)))
             		{
             			adminlog("Error on inserting metatype ".(int)$_GET['delete'], MTS_TYPE_META, MTA_INSERT, E_WARNING);
-            			mtdie("Error on insertion: ". htmlentities(mysqli_error()));
+            			mtdie("Error on insertion: ". $dbConnection->errorCode());
             		}
             	}
             	$info.='<p>New metatype created successfully.<p>';
             	$name = trim($_POST['name']);
             	if( check_type_name( $name ) ) {
-            		if(! $mtdb->query( 'UPDATE meta_t SET name = "' . mysqli_real_escape_string($mtdb->link, $name) . '" WHERE id=' . (int)$_POST['type_id']) )
+            		if(! $dbConnection->executeUpdate('UPDATE meta_t SET name = ? WHERE id = ?', array($name, $_POST['type_id'])))
             		{
             			adminlog("Error updating metatype ".(int)$_GET['delete'], MTS_TYPE_META, MTA_UPDATE, E_WARNING);
-            			mtdie("Error on update: ". htmlentities(mysqli_error()));
+            			mtdie("Error on update: ". $dbConnection->errorCode());
             		}
             	}
             	$info.='<p>Changes to metatype saved successfully.<p>';
             }
             //get all metatypes
-            $metas = $mtdb->getAll("SELECT id, name FROM meta_t");
+            $metas = $dbConnection->fetchAll('SELECT id, name FROM meta_t');
             adminhead('Metatypes');
             adminmenu();

manage-statusbox.php ¶ +4 -4

             /* Handle form submission of new updates */
             function handle_update_form() {
-            	global $error,$info,$mtdb;
+            	global $error,$info,$dbConnection;
             	check_nonce('update-statusbox');
             	$percent = $_POST['update_percentage'];
             		return;
             	}
-            	$mtdb->query( 'INSERT INTO status (published,eta,percentage,text) VALUES( NOW(), FROM_UNIXTIME(' . (int)$eta . '), '. (int)$percent . ', "' . mysqli_real_escape_string($mtdb->link, $text) . '")' );
+            	$dbConnection->executeUpdate('INSERT INTO status (published, eta, percentage, text) VALUES (NOW(), FROM_UNIXTIME(?), ?, ?)', array($eta, $percent, $text));
             	$_POST['update_percentage']=$_POST['update_eta']=$_POST['update_text']='';
             	$info = '<p>Statusbox updated successfully.</p>';
             /* Simple Presets, Select things said before */
-            $presets = $mtdb->getAll('SELECT COUNT(*) as c, percentage, text, CONCAT( percentage, "% - ", text ) as p FROM status GROUP BY p HAVING c>1 ORDER BY c DESC');
+            $presets = $dbConnection->fetchAll('SELECT COUNT(*) as c, percentage, text, CONCAT( percentage, "% - ", text ) as p FROM status GROUP BY p HAVING c > 1 ORDER BY c DESC');
             ?>
             <?php
-            $stats = $mtdb->getAll("SELECT published,eta,percentage,text FROM status ORDER BY published DESC limit 5");
+            $stats = $dbConnection->fetchAll("SELECT published, eta, percentage, text FROM status ORDER BY published DESC LIMIT 5");
             ?>

manage-twitter-presets.php ¶ +3 -3

             		if(0 == $id && !empty($msg)) {
             			// Add a new preset
-            			$mtdb->query( sprintf('INSERT INTO twitter_status (position, message) VALUES (%d, "%s")', $position, mysqli_real_escape_string($mtdb->link, $msg)) );
+            			$dbConnection->executeUpdate('INSERT INTO twitter_status (position, message) VALUES (?, ?)', array($position, $msg));
             			adminlog("Added new preset: $msg", MTS_TWITTER, MTA_ADD);
             		} elseif(empty($msg)) {
             			// Delete an existing preset
-            			$mtdb->query( "DELETE FROM twitter_status WHERE id = $id" );
+            			$dbConnection->executeUpdate('DELETE FROM twitter_status WHERE id = ?', array($id));
             			adminlog("Removed preset: $id", MTS_TWITTER, MTA_ADD);
             		} else {
             			// Modify an existing preset
-            			$mtdb->query( sprintf('UPDATE twitter_status SET position = %d, message = "%s" WHERE id = %d', $position, mysqli_real_escape_string($mtdb->link, $msg), $id) );
+            			$dbConnection->executeUpdate('UPDATE twitter_status SET position = ?, message = ? WHERE id = ?', array($position, $msg, $id));
             		}
             	}
             }

Comments 0

Write
Preview

You need to be logged in to leave comments. Login now

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings